Eliminate internal copy/free inside navilink. (#751)

* C++ improvements inside Vcard. Add test.
* Eternal impedance mismatch on C vs C++ pointer ownership.

diff --git a/navilink.cc b/navilink.cc
index 739ae123d2bf7b75f21a04fce2294842fad9f52c..2c15b620ac4af97d6df5e0cda09a3b633325de8e 100644 (file)
--- a/navilink.cc
+++ b/navilink.cc
@@ -402,9 +402,7 @@ decode_waypoint(const unsigned char* buffer)
   auto* waypt = new Waypoint;
 
   decode_position(buffer + 12, waypt);
-  char* s = xstrdup((char*)buffer + 4);
-  waypt->shortname = s;
-  xfree(s);
+  waypt->shortname = (char*) buffer + 4;
   waypt->icon_descr = icon_table[buffer[28]];
   waypt->SetCreationTime(decode_datetime(buffer + 22));